BUG: fix size()/count() when resamping empty series (#28427) #28459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this is the best way to fix this. |
WillAyd
requested changes
Sep 16, 2019
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
63ee6bd to
ce1a7cc
Compare
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
ce1a7cc to
f3de1d7
Compare
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
f3de1d7 to
990dfb4
Compare
TomAugspurger
approved these changes
Sep 17, 2019
jreback
requested changes
Sep 17, 2019
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
990dfb4 to
e9df4f6
Compare
WillAyd
requested changes
Sep 19, 2019
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
e9df4f6 to
5268c86
Compare
WillAyd
approved these changes
Sep 20, 2019
|
this looked ok, can you merge master and ping on green. |
|
@jreback, For some reason, there's still one requested change (which was done). I guess github is expecting yout to validate it? |
jreback
requested changes
Oct 8, 2019
yes I need to still approve / re-request. |
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
2 times, most recently
from
d0b8b5d to
3df3e17
Compare
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
2 times, most recently
from
bb19e1d to
c57db54
Compare
jreback
requested changes
Oct 16, 2019
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
c57db54 to
a928d03
Compare
jreback
reviewed
Oct 16, 2019
|
@randomstuff can you merge master and ping on green. |
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
a928d03 to
f4845eb
Compare
jreback
requested changes
Nov 17, 2019
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
2 times, most recently
from
1cfdd19 to
e4de858
Compare
randomstuff
force-pushed
the
fix_resample_count_empty_series
branch
from
e4de858 to
aa4e668
Compare
|
@jreback: all green. |
jreback
approved these changes
Nov 19, 2019
|
thanks @randomstuff sometimes these things take a while, thanks for sticking with it! happy to have a followup to consolidate size/count across all grouping types :-> |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff